Repository navigation
feat(catalog): add complete field-driven public filters - #7
Open
herefindalex wants to merge 10 commits into
Open
herefindalex wants to merge 10 commits into
herefindalex wants to merge 10 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public catalogue visitors currently cannot combine conditions across the complete set of product fields and category-specific Specs. This adds server-rendered, progressive GET filters for core fields and every applicable configured Spec, with one admitted published snapshot supplying definitions, options, matching, counts, sorting and pagination.
Validation on final commit
3bda7f1:Current-head GitHub CI passed for both push and pull_request events: PR workflow.
Go: 539 tests passed in 27 packages; PoC build tags: 578 passed in 27 packages;
go vet ./...passed.Frontend: typecheck, 59 tests and full system/public/admin build passed; generated assets match the committed build.
License policy passed. Sample JSON/schema/checksum and deterministic GNU gzip regeneration match; JSON schema validation passed (34 Specs, 1,200 Products, 4,834 Raw values).
Cross-builds passed for Linux amd64, Windows amd64 and macOS amd64/arm64. Native Windows runtime remains unverified.
Actual Linux browser: progressively combine Interface=SPI and supports 4 V, retain sort, paginate 27 results as 24+3, and clear to 28. Repeated native Apply/pagination/clear with CSP
script-src 'none'. Admin checks covered revision conflicts preserving edits, read-only permissions, durable progress and manual preference preservation.Independent whole-branch review: two Important findings and one sorting finding, regraded Important, fixed in one pass with observed RED→GREEN regressions; no findings deferred.
Limits and integration: