Repository navigation
Verifier interface instead of ModelChecker - #1122
Merged
Merged
Conversation
Performance comparisonLinux x64Benchmark detailsMemory model: vmm
Memory model: aarch64
Memory model: power
Total
2 benchmark(s) omitted because both averages were below 5 seconds. macOS ARM64Benchmark detailsMemory model: vmm
Memory model: aarch64
Memory model: power
Total
|
ThomasHaas
force-pushed
the
verifierInterface
branch
from
September 29, 2026 08:40
c3a578d to
9526ab9
Compare
hernanponcedeleon
force-pushed
the
verifierInterface
branch
from
September 30, 2026 12:51
9526ab9 to
fbd148e
Compare
hernanponcedeleon
force-pushed
the
verifierInterface
branch
from
October 1, 2026 10:29
fbd148e to
999bd88
Compare
ThomasHaas
force-pushed
the
verifierInterface
branch
from
October 1, 2026 17:45
999bd88 to
ad4f9d1
Compare
Collaborator
Author
|
I made a change that affects a lot of code: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new
Verifierinterface which is implemented byAssumeSolver/RefinementSolverandVerificationTaskSolveruses this interface instead of the previousModelCheckerclass. The interface is not SMT-specific and requires the solver to just return aVerificationResult(the result's model is still an IREvaluator, which is currently SMT-specific though).I renamed
ModelCheckertoSMTModelCheckerand simplified it. It is no longer task-specific and simply provides utility for SMT-based approaches (essentially just managing prover and solver context).Possible TODOs:
Move the static utility processing and analysis methods from[EDIT: Won't move.]SMTModelCheckerto somewhere else.Maybe rename[EDIT: Not important]VerifiertoVerifierBackendto make it more distinguished fromVerificationTaskSolverwhich usesVerifier(Backend)to solve tasks.Add new Exception types toTaskSolversand/orVerifiers. OurVerificationTaskSolver.runthrowsSolverException, InterruptedException, InvalidConfigurationExceptionof which theSolverExceptionoriginates from SMT solvers (though we could reuse the exception beyond just SMT solvers).Currently, I have not decided what exceptions
Verifier.verifyshould throw and simply omitted them: this forces all actually thrown exceptions to be wrapped into aRuntimeException.