Repository navigation
Name the Object Browser's list rows by their names (#1299) - #1302
Merged
Merged
Conversation
…the text they show (#1299) The Object Browser's class, member and search lists named their rows by their view models' type, which the dump drops: no name, no select by value, and a selection read as "ListItem". The three view models now name themselves, and a list row its peer gives no usable name is named by the text it shows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, so it named rows no tool accepts (#1299 review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1299.
The Object Browser's class, member and search lists named their rows by their view models' type. A row's peer names it by its item's
ToString(), and these view models have none of their own. The dump drops a type name, so these rows had no name,selectby value couldn't find them, andinspect_elementnamed the selection "ListItem".OBClassViewModel,OBMemberViewModelandOBSearchResultViewModelnow name themselves by their names, asOBLibraryViewModelbeside them already does.Review
One adversarial reviewer, using headless probes and a survey of every
ListBoxandComboBoxin the IDE.Resolveandselectmatch on the peer's name, so the dump showed a name no tool acceptedItems[i].ToString()ToStringsOBSearchResultViewModelcould name itself with its location to tell same-named hits apart[#n]paths as beforeThe reviewer confirmed that nothing else uses these view models'
ToString: logging, sorting and filtering read.Name. No test asserts a type name, and screen-reader names improve too.Mutation-checked: removing
OBClassViewModel.ToStringfails the test. Integration 1447 passes.🤖 Generated with Claude Code