fix: resolve pending intervaltree work and guard releases - #13
Merged
Merged
Conversation
BREAKING CHANGE: findOneByLengthStartingAt now selects by clipped start, then end, matching searchByLengthStartingAt; previously it selected by original start. ArrayIntervalCollection also returns canonical arrays and rejects nonpositive length queries.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Merging this PR will degrade performance by 45.46%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | searchPoint (array) |
29.3 s | 80.4 s | -63.58% |
| ❌ | searchOverlap (array) |
30.8 s | 80.9 s | -61.91% |
| ⚡ | equals |
21.1 ms | 18 ms | +16.97% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix/pending-intervaltree-beads (d86e7fd) with master (08f5cb4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query arrays and iteration now have canonical returned-bound order, independent of how the tree was built. Length selection uses the same clipped ordering in both adapters, so
[[0,10],[3,5]].findOneByLengthStartingAt(1,4)returns[4,5).This also corrects the README date example, replaces the string-based debug build guard with CJS/ESM behavior probes, records the generic-library glossary and derived-members design, and adds packed Focuster freelist and release-label CI checks. Shared collectionOps implementation remains separately deferred.
Breaking change: 2.1.0 documents selection by original start. The new selection compares clipped start, then end; the conventional commit marks this for a major release.
toSorted()remains a compatibility alias. Nothing is published by this PR alone.Validation: 281 unit tests, the full property model check, coverage thresholds, lint, typecheck, CJS/ESM packed compatibility, six automation regression tests, actionlint, and a live release-label probe pass. Focuster's published-2.1.0 upgrade passes 30 freelist unit tests and 11 targeted browser tests, with a clean build warning gate. The manual GitHub CI run passed the packed-consumer check against Focuster's locked dependency tree, verified private checkout authentication, and confirmed restoration after the isolated override. The new findOne selection is marked for a major release; package publication remains a later release step.