Skip to content

Move MariaDB source to home-assistant/app-mariadb - #4905

Merged
sairon merged 1 commit into
masterfrom
split-mariadb
Oct 26, 2026
Merged

sairon merged 1 commit into
masterfrom
split-mariadb

Conversation

@sairon

@sairon sairon commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Keep only the app index metadata in mariadb/.

Refs #4881

Summary by CodeRabbit

  • New Features
    • Added MariaDB to the available app list.
  • Changes
    • The bundled MariaDB service and its database setup, maintenance, and backup table-locking features are no longer included.
    • Updated the app list ordering for Matter Server and SSH.

Keep only the app index metadata in mariadb/.

Refs #4881
@sairon

sairon commented Oct 26, 2026

Copy link
Copy Markdown
Member Author

The .apps.yml and .yamllint were not sorted, so this PR drive-by fixes it.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 979af084-b4f0-4ee1-823e-4021adabba59
Commits

Reviewing files that changed from the base of the PR and between 2c0a216 and c79a1f3.

Files selected for processing: 41
  • .apps.yml
  • .yamllint
  • mariadb/Dockerfile
  • mariadb/build.yaml
  • mariadb/rootfs/etc/my.cnf.d/mariadb-server.cnf
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/dependencies.d/mariadb-pre
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/finish
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/run
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/timeout-kill
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/dependencies.d/mariadb
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/finish
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/notification-fd
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/run
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/dependencies.d/mariadb-lock-core
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/down
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/finish
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/run
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/up
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock/contents.d/mariadb-lock-core
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock/contents.d/mariadb-lock-post
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/dependencies.d/mariadb-core
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/down
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/finish
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/run
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/up
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-pre/dependencies.d/base
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-pre/run
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-pre/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-pre/up
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb/contents.d/mariadb-core
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb/contents.d/mariadb-post
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb/contents.d/mariadb-pre
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/mariadb
  • mariadb/rootfs/usr/bin/lock-tables-for-backup
  • mariadb/rootfs/usr/bin/unlock-tables-for-backup
Files with no reviewable changes: 28
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/timeout-kill
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-pre/up
  • mariadb/rootfs/usr/bin/unlock-tables-for-backup
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/finish
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/run
  • mariadb/build.yaml
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/down
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/finish
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/down
  • mariadb/Dockerfile
  • mariadb/rootfs/usr/bin/lock-tables-for-backup
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/notification-fd
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/finish
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/up
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-pre/type
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/finish
  • mariadb/rootfs/etc/my.cnf.d/mariadb-server.cnf
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-core/run
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/run
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-post/up
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock-post/run
  • mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-pre/run

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The app list adds MariaDB and reorders Matter Server and SSH. The MariaDB build files, server configuration, service startup and initialization files, and backup table-lock support are removed.

Changes: MariaDB app

Layer / File(s) Summary
App catalog and lint entries
.apps.yml, .yamllint
The app list adds MariaDB and reorders Matter Server and SSH. The yamllint ignore list adds /mariadb/config.yaml.
Build and server configuration
mariadb/Dockerfile, mariadb/build.yaml, mariadb/rootfs/etc/my.cnf.d/mariadb-server.cnf
The MariaDB Dockerfile, architecture build mappings, and server configuration are removed.
Startup and initialization services
mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-{pre,core,post}/...
The MariaDB pre-start, core, and post-start service files are removed, including startup and initialization scripts.
Backup table-lock services
mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-lock*/..., mariadb/rootfs/usr/bin/{lock-tables-for-backup,unlock-tables-for-backup}
The backup table-lock service files and command wrappers are removed.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: lmagyar, frenck, pvizeli

Merge Risk: Minimal · up to c79a1

No actionable merge-blocking risk was established from the available evidence.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the primary change: moving the MariaDB source to home-assistant/app-mariadb.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sairon
sairon requested a review from agners October 26, 2026 10:55
@sairon
sairon merged commit 8938c04 into master Oct 26, 2026
7 checks passed
@sairon
sairon deleted the split-mariadb branch October 26, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants