Skip to content

Move Git pull source to home-assistant/app-git-pull - #4906

Merged
sairon merged 1 commit into
masterfrom
split-git-pull
Oct 26, 2026
Merged

sairon merged 1 commit into
masterfrom
split-git-pull

Conversation

@sairon

@sairon sairon commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Keep only the app index metadata in git_pull/.

Refs #4879

Summary by CodeRabbit

  • Updates
    • The Git Pull app entry now references its repository and container image hosted outside this project.
  • Changes
    • The locally maintained Git Pull build and synchronization files have been removed.

Keep only the app index metadata in git_pull/.

Refs #4879
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9a043c9a-7679-405c-9e3a-a460ca4f44bb
Commits

Reviewing files that changed from the base of the PR and between 8938c04 and 2af6432.

Files selected for processing: 5
  • .apps.yml
  • .yamllint
  • git_pull/Dockerfile
  • git_pull/build.yaml
  • git_pull/data/run.sh
Files with no reviewable changes: 3
  • git_pull/build.yaml
  • git_pull/data/run.sh
  • git_pull/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The registry adds a git_pull entry pointing to home-assistant/app-git-pull. The local Dockerfile, build configuration, and runtime script are removed. The YAML lint ignore list adds /git_pull/config.yaml.

Changes: Git Pull app

Layer / File(s) Summary
Register the app
.apps.yml, .yamllint
The registry adds the git_pull repository, target, and image. The YAML lint ignore list adds /git_pull/config.yaml.
Remove local build and runtime
git_pull/Dockerfile, git_pull/build.yaml, git_pull/data/run.sh
The Dockerfile and architecture build configuration are removed. The runtime script and its configuration, synchronization, validation, and restart logic are removed.

Priority: Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Refactor

Suggested reviewers: raypappa, pvizeli

Merge Risk: Minimal · up to 2af64

The migration is consistent with the intended repository split and has no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: moving the Git pull source to home-assistant/app-git-pull.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sairon
sairon merged commit a5e5aaa into master Oct 26, 2026
7 checks passed
@sairon
sairon deleted the split-git-pull branch October 26, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants