[sairon]

Keep only the app index metadata in mosquitto/.

Refs #4883

Summary by CodeRabbit

• New Features
  • Added Mosquitto to the app catalog, linked to its published app image.
• Chores
  • Updated configuration to support linting the Mosquitto configuration file.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 512f849b-f534-4433-aeef-3ce86d110162

Commits

Reviewing files that changed from the base of the PR and between 8938c04 and 72091a8.

Files selected for processing: 14

• .apps.yml
• .yamllint
• mosquitto/Dockerfile
• mosquitto/build.yaml
• mosquitto/patches/0001-Fix-builtin-websockets-dropping-the-session-on-an-empty-data-frame.patch
• mosquitto/rootfs/etc/cont-init.d/mosquitto.sh
• mosquitto/rootfs/etc/cont-init.d/nginx.sh
• mosquitto/rootfs/etc/services.d/mosquitto/discovery
• mosquitto/rootfs/etc/services.d/mosquitto/finish
• mosquitto/rootfs/etc/services.d/mosquitto/run
• mosquitto/rootfs/etc/services.d/nginx/finish
• mosquitto/rootfs/etc/services.d/nginx/run
• mosquitto/rootfs/usr/share/tempio/mosquitto.gtpl
• mosquitto/rootfs/usr/share/tempio/nginx.gtpl

Files with no reviewable changes: 12

• mosquitto/build.yaml
• mosquitto/rootfs/etc/services.d/nginx/run
• mosquitto/rootfs/usr/share/tempio/nginx.gtpl
• mosquitto/Dockerfile
• mosquitto/rootfs/etc/cont-init.d/nginx.sh
• mosquitto/rootfs/etc/services.d/nginx/finish
• mosquitto/rootfs/etc/services.d/mosquitto/finish
• mosquitto/rootfs/etc/services.d/mosquitto/run
• mosquitto/rootfs/etc/cont-init.d/mosquitto.sh
• mosquitto/rootfs/usr/share/tempio/mosquitto.gtpl
• mosquitto/rootfs/etc/services.d/mosquitto/discovery
• mosquitto/patches/0001-Fix-builtin-websockets-dropping-the-session-on-an-empty-data-frame.patch

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The change registers the Mosquitto app in .apps.yml and adds its configuration path to the yamllint ignore list. It removes the local Docker build definition, patch, configuration templates, initialization scripts, and Mosquitto and NGINX service scripts.

Changes: Mosquitto app

Layer / File(s)	Summary
App registration and lint configuration .apps.yml, .yamllint	Adds a Mosquitto app mapping to the home-assistant/app-mosquitto repository, image, and target. Adds /mosquitto/config.yaml to the yamllint ignore list.
Local build inputs and image assembly mosquitto/build.yaml, mosquitto/patches/*, mosquitto/Dockerfile	Removes the architecture-specific build configuration, the WebSocket empty-frame patch, and the Dockerfile that built Mosquitto and its Go auth plugin.
Broker and authentication configuration mosquitto/rootfs/etc/cont-init.d/*, mosquitto/rootfs/usr/share/tempio/*	Removes the Mosquitto initialization script and configuration template, plus the NGINX initialization script and configuration template.
Broker discovery and service lifecycle mosquitto/rootfs/etc/services.d/mosquitto/*, mosquitto/rootfs/etc/services.d/nginx/*	Removes the Mosquitto startup, discovery, and finish scripts, and the NGINX startup and finish scripts.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Suggested reviewers: frenck

Merge Risk: Minimal · up to 72091

The Mosquitto source move is mergeable with no identified regression.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title states the main change: the Mosquitto broker source moves to home-assistant/app-mosquitto. The raw summary shows the mosquitto/ source files deleted and .apps.yml mapping the app to that rep…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title states the main change: the Mosquitto broker source moves to home-assistant/app-mosquitto. The raw summary shows the mosquitto/ source files deleted and .apps.yml mapping the app to that repository, and the objectives say the PR keeps only app index metadata in mosquitto/. The title matches this primary change and is specific enough for a teammate scanning history.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}