Skip to content

fix: signing baskets follow NextGenPSD2 1.3.16 and belong to the TPP that created them - #105

Closed
hongwei1 wants to merge 27 commits into
base/signing-basket-a5c5f53acfrom
feature/signing-basket-conformance
Closed

hongwei1 wants to merge 27 commits into
base/signing-basket-a5c5f53acfrom
feature/signing-basket-conformance

docs: how to operate signing baskets

7cf8860
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 6, 2026 in 41s

Annotations

Check failure on line 141 in obp-api/src/main/scala/code/api/berlin/group/v1_3/SigningBasketExecution.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEQj-Typ71Ff-PlYv8x&open=AaEQj-Typ71Ff-PlYv8x&pullRequest=105

Check failure on line 116 in obp-api/src/test/scala/code/api/berlin/group/v1_3/SigningBasketSignedRequestTest.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "signing-baskets" 4 times.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9xWoITl3V147M9U&open=AaEPw9xWoITl3V147M9U&pullRequest=105

Check failure on line 92 in obp-api/src/main/scala/code/api/berlin/group/v1_3/Http4sBGv13SigningBaskets.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of conditional operators (5) used in the expression (maximum allowed 3).

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9r7oITl3V147M9N&open=AaEPw9r7oITl3V147M9N&pullRequest=105

Check failure on line 637 in obp-api/src/test/scala/code/api/berlin/group/v1_3/SigningBasketServiceSBSApiTest.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "POST authorisation" 3 times.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9xNoITl3V147M9S&open=AaEPw9xNoITl3V147M9S&pullRequest=105

Check failure on line 633 in obp-api/src/test/scala/code/api/berlin/group/v1_3/SigningBasketServiceSBSApiTest.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "GET basket" 3 times.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9xNoITl3V147M9P&open=AaEPw9xNoITl3V147M9P&pullRequest=105

Check warning on line 650 in obp-api/src/main/scala/code/api/util/APIUtil.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This branch's code block is the same as the block for the branch on line 641.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9hOoITl3V147M9L&open=AaEPw9hOoITl3V147M9L&pullRequest=105

Check failure on line 635 in obp-api/src/test/scala/code/api/berlin/group/v1_3/SigningBasketServiceSBSApiTest.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "DELETE basket" 3 times.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9xNoITl3V147M9R&open=AaEPw9xNoITl3V147M9R&pullRequest=105

Check warning on line 209 in obp-api/src/main/scala/code/api/berlin/group/v1_3/SigningBasketExecution.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused function parameter "basketId".

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEQihvQiag9PFnyaWJN&open=AaEQihvQiag9PFnyaWJN&pullRequest=105

Check failure on line 611 in obp-api/src/test/scala/code/api/berlin/group/v1_3/SigningBasketServiceSBSApiTest.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "PSU-ID" 6 times.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEQj-gbp71Ff-PlYv8y&open=AaEQj-gbp71Ff-PlYv8y&pullRequest=105

Check failure on line 43 in obp-api/src/test/scala/code/signingbaskets/MappedSigningBasketProviderTest.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "consumer-1" 9 times.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9xeoITl3V147M9V&open=AaEPw9xeoITl3V147M9V&pullRequest=105

Check failure on line 647 in obp-api/src/main/scala/code/api/util/APIUtil.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of conditional operators (4) used in the expression (maximum allowed 3).

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9hOoITl3V147M9M&open=AaEPw9hOoITl3V147M9M&pullRequest=105

Check failure on line 156 in obp-api/src/test/scala/code/api/berlin/group/v1_3/SigningBasketServiceSBSApiTest.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "{"scaAuthenticationData":"123"}" 3 times.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9xMoITl3V147M9O&open=AaEPw9xMoITl3V147M9O&pullRequest=105

Check failure on line 100 in obp-api/src/test/scala/code/api/berlin/group/v1_3/SigningBasketServiceSBSApiTest.scala

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "signing-baskets" 16 times.

See more on https://sonarcloud.io/project/issues?id=hongwei1_OBP-API&issues=AaEPw9xNoITl3V147M9Q&open=AaEPw9xNoITl3V147M9Q&pullRequest=105