feat(core): pointerdrag.js pointer-events based drag toolkit#211
Merged
Conversation
This was referenced Jul 23, 2026
Contributor
|
Tested together with horde/kronolith#76 — fixes horde/kronolith#74 (drag ghost now follows the cursor when scrolling mid-drag) and the resize issues. |
TDannhauer
approved these changes
Jul 23, 2026
Contributor
There was a problem hiding this comment.
Review
Looks good as a shared Pointer Events drag primitive. The design (thin toolkit, consumer-owned state, fixed-position ghosts, pointer capture, click-swallow after a real drag) is the right replacement path for dragdrop2 in apps that opt in.
Together with horde/kronolith#76 this addresses horde/kronolith#74 for month-view mid-drag scroll (viewport-fixed ghost + clientX/clientY).
Notes (non-blocking)
- Wheel/trackpad scroll mid-drag does not replay move handlers (only edge auto-scroll does). Month ghosts stay correct because they are
position: fixed; consumers that derive layout fromscrollTopmay still want ascrolllistener that replays the last pointer position. - Consider
touch-action: noneon the source while a drag is pending/active so touch does not steal the gesture. releasePointerCaptureonly runs fromdestroy(); fine on normalpointerup, but a short comment would help future readers.
Approve. Do we need the Wheel/trackpad thing?
Member
Author
|
Applied review feedback in 2f24cdf:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Drag & Drop primitives library which can replace the prototypejs/scriptaculous based dragdrop2.js library.
#211 and horde/kronolith#76 together seem to fix horde/kronolith#74 (calendar event drag and drop move / resize) based on more modern javascript