-
Notifications
You must be signed in to change notification settings - Fork 0
feat: widen the provisioning tools, and mark the ones that can destroy data #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
37def5c
c987d76
a56abc8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,18 @@ | |
| except PackageNotFoundError: | ||
| __version__ = "0.0.0+unknown" | ||
|
|
||
| from hotdata_framework import HotdataClient, ManagedDatabase, QueryResult, from_env | ||
| from hotdata_framework import ( | ||
| HotdataClient, | ||
| ManagedDatabase, | ||
| QueryResult, | ||
| TablePartitionKey, | ||
| TableSortKey, | ||
| from_env, | ||
| ) | ||
|
|
||
| from hotdata_langchain._sql import DISTANCE_FUNCTIONS, DistanceMetric | ||
| from hotdata_langchain.databases import ( | ||
| LoadMode, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: re-export Both types now sit in the public signature of Without the re-export, a caller who reached Add both names to line 10 and to |
||
| create_managed_database, | ||
| list_managed_databases_json, | ||
| load_managed_table, | ||
|
|
@@ -75,6 +83,7 @@ | |
| DEFAULT_LIST_DATABASES_TOOL_NAME, | ||
| DEFAULT_LOAD_TABLE_TOOL_NAME, | ||
| DEFAULT_SQL_TOOL_NAME, | ||
| DESTRUCTIVE_TOOL_NAMES, | ||
| execute_sql_json, | ||
| make_hotdata_tools, | ||
| result_rows_for_llm, | ||
|
|
@@ -94,6 +103,7 @@ | |
| "DEFAULT_SEARCH_TOOL_NAME", | ||
| "DEFAULT_SEMANTIC_TOOL_NAME", | ||
| "DEFAULT_SQL_TOOL_NAME", | ||
| "DESTRUCTIVE_TOOL_NAMES", | ||
| "DISTANCE_COLUMN", | ||
| "DISTANCE_FUNCTIONS", | ||
| "RRF_K", | ||
|
|
@@ -106,12 +116,15 @@ | |
| "HotdataClient", | ||
| "HotdataToolError", | ||
| "HotdataVectorStore", | ||
| "LoadMode", | ||
| "ManagedDatabase", | ||
| "QueryResult", | ||
| "SearchIndex", | ||
| "SearchRoute", | ||
| "SearchStrategy", | ||
| "SearchableColumn", | ||
| "TablePartitionKey", | ||
| "TableSortKey", | ||
| "__version__", | ||
| "bm25_search_json", | ||
| "bm25_search_sql", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit: drop the blank first line of the code block (not blocking). Removing the
from hotdata_framework import TableSortKeyline left the blank line that separated it from the call.