Implemented support for moqui login and logic to run service on releasing order / items (#293) - #294
Open
amansinghbais wants to merge 10 commits into
Open
amansinghbais wants to merge 10 commits into
amansinghbais wants to merge 10 commits into
Conversation
1 task
…nt routingGroupId (hotwax#293)
…nused console statement (hotwax#293)
…empty settingValue (hotwax#293)
patelanil
reviewed
Aug 27, 2026
patelanil
left a comment
patelanil
left a comment
There was a problem hiding this comment.
Log message format review
I reviewed the log/error messages added in this PR against our best practice: log-messages.md.
These added messages do not follow the [Entity] [Context] - [Action/Outcome/Issue] pattern:
Maarg instance is not setup for this account.
Suggest:Maarg Instance - Not set up for this accountFailed to schedule routing.
Suggest:Routing - Failed to scheduleSome of the configuration of the app is missing.
Suggest:App Configuration - Required configuration missing
Dynamic IDs belong in the [Context] block and the action text should stay constant, so messages group and count cleanly in Grafana/Loki during log analysis. Please align these before merge.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#293
Short Description and Why It's Useful
Related PR: hotwax/launchpad#125
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance