Skip to content

fix(subject): remove unique validation rule on subject name #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trtajim merged 1 commit into from
Sep 8, 2026
Merged

fix(subject): remove unique validation rule on subject name #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Http/Requests/Subject/StoreSubjectRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ protected function prepareForValidation(): void
public function rules(): array
{
return [
'name' => ['required', 'string', 'max:100', 'min:3', 'unique:subjects,name'],
'name' => ['required', 'string', 'max:100', 'min:3'],
'english_name' => ['nullable', 'string', 'max:100'],
'slug' => ['required', 'string', 'max:100', 'unique:subjects,slug'],
'tailwind_format' => ['required', 'string', 'max:100'],
Expand Down
2 changes: 1 addition & 1 deletion app/Http/Requests/Subject/UpdateSubjectRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function rules(): array
$subject = $this->route('subject');

return [
'name' => ['sometimes', 'string', 'max:100', 'min:3', Rule::unique('subjects', 'name')->ignore($subject->id)],
'name' => ['sometimes', 'string', 'max:100', 'min:3'],
'english_name' => ['nullable', 'string', 'max:100'],
'tailwind_format' => ['sometimes', 'string', 'max:100'],
'icon' => ['sometimes', 'string', 'max:50'],
Expand Down
32 changes: 32 additions & 0 deletions tests/Feature/SubjectManagementTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,35 @@
'sort_order',
]);
});

test('admin can create subjects with same name in different courses', function () {
$admin = adminUserWithPermissions(['view admin', 'create subjects']);

Subject::create([
'name' => 'Physics',
'english_name' => 'Physics',
'slug' => 'hsc-physics',
'course' => 'hsc',
'tailwind_format' => 'bg-slate-500',
'icon' => 'book-open',
'sort_order' => 1,
]);

$response = $this->actingAs($admin)->post('/admin/subjects', [
'name' => 'Physics',
'english_name' => 'Physics',
'course' => 'ssc',
'tailwind_format' => 'bg-slate-500',
'icon' => 'book-open',
'sort_order' => 1,
]);

$response->assertRedirect();
$response->assertSessionHas('success', 'Subject created successfully.');

$this->assertDatabaseHas('subjects', [
'name' => 'Physics',
'course' => 'ssc',
'slug' => 'ssc-physics',
]);
});