Conversation
Consumers pin central Dagger modules at exact SHAs, and fleet policy checked that each pin was well-formed but not that it was new enough. Repos could stay pinned below a mandatory fix (dd19871, #46) without anyone noticing, which blocked the aml-filter release. REQUIRED_MINIMUM in fleet_policy.py holds a reviewed floor per central module, starting with portfolio-foundation -> dd19871. The GitHub reader compares every floored module revision in a consumer's resolved Dagger graph against the floor (compare/<floor>...<pin>) and against central main (compare/<pin>...main). Both must be ahead or identical. Otherwise, including when there is no common history or the evidence is missing, the scan reports pin-below-required-minimum and fails. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
The fleet scan only checked repositories listed by hand in repository_expectations. agentic-saga and agentic-context-service pin hseshadr/ci modules but were never listed, so no fleet rule ran on them. - Add both to repository_expectations with the full consumer contract (sole Dagger check, conversation resolution, no rollout exception; both already declare shared foundation). - New fleet_coverage module: list every public hseshadr repository, read its default-branch dagger.json, and report uncovered-consumer for any active repository that pins a github.com/hseshadr/ci module but is missing from the list. Listing or config read errors fail closed. - scan_repository now turns FleetAccessError into an evidence-unreadable finding, so one unreadable repository (agentic-context-service has no branch protection on main) no longer hides every later result. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
…elease-lineage-module
…ger args
Publisher lineage moves out of consumer `run:` steps into two
portfolio-foundation functions. release-lineage and release-provenance fail
unless GitHub's run records show a successful release-candidate.yml dispatch
for exactly the expected SHA, run by this repository's in-progress main
publish.yml, with main containing both commits. That blocks a dispatch on a
tag named `main` from publishing its own bytes. release-provenance also
returns npm's provenance context, built from the publish run record.
The fleet policy accepts that exact leading step (publisher-lineage for
anything weaker) and a consumer publisher loaded at `@${{ github.sha }}`, so
edgeproc-core and privacy-core can publish with no shell step and no
exemption. It also reports dagger-args-expression for `${{ inputs.* }}`,
`${{ github.event.* }}` or `${{ github.head_ref }}` in any dagger-for-github
input the action pastes into bash.
Fixtures that pasted the workflow_run head SHA into args as compliant now
pass it through env; the policy reports the old shape.
Fixes #49
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
This was referenced Sep 25, 2026
Split evidence construction and the repository part of the provenance context into named helpers (python-quality function-length rule). The provenance JSON keys are now emitted sorted. Behavior is unchanged; lineage.py stays at 100% line and branch coverage. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
hseshadr
added a commit
to hseshadr/edgeproc-core
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
hseshadr
added a commit
to hseshadr/privacy-core
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
hseshadr
added a commit
to hseshadr/aml-filter
that referenced
this pull request
Sep 25, 2026
dagger-for-github pastes `call` raw into a bash script, so the fleet rule dagger-args-expression (hseshadr/ci#50) forbids ${{ inputs.* }}, ${{ github.event.* }} and ${{ github.head_ref }} in every input it pastes (args, call, shell, dagger-flags, workdir, cloud-token). Both delivery steps now get RELEASE_SHA through env: and pass --release-id="$RELEASE_SHA:$GITHUB_RUN_ID"; the queue step passes --run-id="$GITHUB_RUN_ID". Checkout ref keeps the same source expression (not Dagger args). Contract tests in both suites fail while any such expression is in a Dagger script input; a mutation re-adding one to publish-watchlist.yml turns both red. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
This was referenced Sep 25, 2026
hseshadr
added a commit
to hseshadr/almamesh
that referenced
this pull request
Sep 25, 2026
…seshadr/ci#50) dagger-for-github pastes `args` into bash, so `${{ github.event.* }}` there is a shell-injection sink (fleet rule dagger-args-expression, hseshadr/ci#50). deploy.yml now passes head_sha, run id, and attempt as HEAD_SHA, WORKFLOW_RUN_ID, and RUN_ATTEMPT in the step env and references them quoted. CONTRACT REVERSAL: the ingress and deploy-workflow contracts used to REQUIRE `--expected-sha=${{ github.event.workflow_run.head_sha }}` (and run id and attempt) in args. They are inverted, not deleted: they now forbid those forms and require the env + quoted form. A new fleet-rule test scans every workflow's dagger-for-github bash-pasted inputs, including live-probe.yml. It was red on deploy.yml before the migration, and four mutants cover inputs.*, github.event.*, head_ref, and spacing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
This was referenced Sep 25, 2026
Merged
hseshadr
added a commit
that referenced
this pull request
Sep 26, 2026
Brings in #47 -> #48 -> #50 -> #52 so this PR merges last without conflicts. Their README lines move to the new layout: the consumer list (now with agentic-context-service and agentic-saga), the uncovered-consumer failure and the required-minimum pin floor go to docs/ARCHITECTURE.md "What dagger call fleet checks", with plain one-line versions in the README intro. Publisher lineage and the dagger-args-expression rule are noted there too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Two fleet-policy security gaps from #49, closed in the central module instead of in consumer shell.
portfolio-foundationgainsrelease-lineage(PyPI) andrelease-provenance(npm). Each fails unless GitHub's run records show all of the following: the candidate run is a successfulrelease-candidate.ymldispatch for exactlyHEAD_SHA; the publish run is this repo's in-progresspublish.ymlworkflow_runonmain; andmaincontains both commits (branches/mainendpoint, so a tag namedmaincan't stand in for the branch).release-provenancealso returns npm'sgithub-context.json, built from the publish run record instead of caller text. The fleet policy accepts exactly this leading step (publisher-lineagefor anything weaker) and a consumer publisher loaded at@${{ github.sha }}. edgeproc-core and privacy-core can then drop theirrun:steps with no exemption.dagger-args-expression. The policy now rejects${{ inputs.* }},${{ github.event.* }}and${{ github.head_ref }}in everydagger-for-githubinput the action pastes into bash (args,call,shell,dagger-flags,workdir,cloud-token).moduleis exempt because the action passes it asINPUT_MODULEenv.Claim touched: "a publisher only ships bytes built from
main" and "no caller-controlled text reaches script".Fixes #49
Merge order
This PR is stacked on #47 (
feat/fleet-minimum-pin) and #48 (feat/fleet-coverage). Merge it after both. Its base ismain, so until they merge, the diff also shows their commits.Contract reversal (read this)
NPM_BRIDGEand the planned-PyPI fixture intest_fleet_policy.pypasted--expected-sha=${{ github.event.workflow_run.head_sha }}into args and asserted that shape was compliant. They now pass it throughenv:as--expected-sha="$HEAD_SHA". The policy reports the old shape.Fleet impact after merge (new
dagger-args-expressionfindings on currentmains)release-candidate.yml(inputs.tag),publish.ymlx2 (workflow_run.head_sha)deploy.yml(workflow_run.head_sha,.id,.run_attempt)deploy.yml(same three)deploy.yml,publish-watchlist.yml(github.event.workflow_run.head_sha)dagger.yml,dagger-security.yml(github.event.repository.privateinside a conditional)These values are GitHub-generated, but the rule is literal by design. It flags every event expression, with no judgement about which ones are safe.
Evidence
pypi-shape/npm-shape)poe gate(lint, mypy, xenon A, pytest, branch floor)portfolio-foundationlineage testsRUN_ID/HEAD_SHAfrom the event) droppedcompare) check droppedmaincases + publisher-not-on-main)dagger -m .../portfolio-foundation@3de1c4b functionsrelease-lineage,release-provenancelistedrelease-lineageon privacy-core run 35935478810 + completed publish runrelease-lineageon failed candidate run 35930137724de1c0b8contained in main; privacy-core#48 PR-head8de4231refused "not contained in main"Not verified
portfolio-foundationpoe gatelocally. On this machine it stops at 86% total coverage even on the base branch, before this change (247 passed, 1 skipped). ci's hosted CI does not run module gates.Consumer drafts pinned at this PR's head: hseshadr/edgeproc-core#60 and hseshadr/privacy-core#49; assay injection fix: hseshadr/assay#74. They get re-pinned to the merge SHA after this merges.
🤖 Generated with Claude Code
https://claude.ai/code/session_015oBArfm762nN1r4F4Fst5a