Add opt-in Windows Korean hardware keyboard support - #102
Draft
zeberity123 wants to merge 2 commits into
Draft
zeberity123 wants to merge 2 commits into
zeberity123 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SDIC Korea LTBK21 connected to an iPad did not reliably toggle the Windows host's Korean IME. Translating the language shortcut to Right Alt enabled switching, but keeping its accompanying Ctrl held until the keyboard's delayed key-up could affect subsequent typing.
This adds Windows Korean Keyboard, off by default, under Settings > Interactivity. When enabled, it uses GameController physical keyboard events with a UIKit fallback and translates Hangul/LANG1, Right Alt, Ctrl+Space, and Shift+Space into a single Right Alt tap. Hardware language shortcuts release accompanying modifiers immediately. Consumed modifiers remain released until physical key-up, and stale UIKit flags cannot turn the next ordinary Space into another language toggle.
It also provides a touch 한/영 button and an optional backtick mapping, off by default. Users should select Korean Microsoft IME with Korean keyboard (101-key) Type 1 on Windows. Korean mode repurposes Right Alt and overrides Option-as-Command; disabling it preserves the existing input path.
Validation:
The existing release workflow, bundle identifier, and download links are unchanged. The Caps Lock Esc/F-key mapping is kept in a separate follow-up.
The UIKit text-duplication guard uses a 150 ms window after physical keyboard events. The reported mixed-keyboard test passed, but this is not a claim of compatibility with every keyboard or iPadOS input source.