Repository navigation
kernels: split out digest validation validation and raise on two different kernels with the same ID - #895
Draft
danieldk wants to merge 5 commits into
Draft
kernels: split out digest validation validation and raise on two different kernels with the same ID#895danieldk wants to merge 5 commits into
danieldk wants to merge 5 commits into
Conversation
Also remove digest checking from `SignatureValidator`.
danieldk
force-pushed
the
digest-validator
branch
from
October 9, 2026 15:31
f682460 to
7e53283
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change splits out digest validation into a separate validator,
DigestValidator. We also separate out the receipt caches for digest and signature validation. This allows us to unconditionally enable digest validation and raise when digest validation fails.Building on this, we also update the importing code to raise when two different kernels have the same kernel id.