Support per-layer cache configuration and attention-mask selection - #48178
Open
eladsegal wants to merge 12 commits into
Open
Support per-layer cache configuration and attention-mask selection#48178eladsegal wants to merge 12 commits into
eladsegal wants to merge 12 commits into
Conversation
This reverts commit 7937a3b.
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates cache construction and attention-mask selection to support models whose layers use different cache settings.
Previously,
DynamicCacheandStaticCachederived one set of initialization arguments from the top-level config and reused it for every layer. They now initialize each cache layer from its corresponding layer config, preserving per-layersliding_window,attention_chunk_size, andnumber_of_conv_statesvalues.Cache and mask helpers also inferred cache metadata from a fixed layer, which could select a linear-attention layer or an unpopulated KV layer instead of one representing the requested attention pattern. When no explicit
layer_idxis provided, they now select a representative KV layer: dynamic caches prefer a populated matching layer, while static caches use the first matching KV layer in their fixed layout.Who can review?
@ArthurZucker
@Cyrilvallez
(Re-opening of #47901)