fix: use milliseconds for bash timeouts - #33
Merged
Conversation
…on-hang-and-timeout-issues HumanLayer-Session: https://app.dev.codelayer.gg/sessions/01a05ebb-17cb-76aa-b2da-bae9e833d912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeouttotimeout_msWhy
Models were emitting values such as
120000with millisecond intent, while Fold interpreted them as seconds. A two-minute timeout therefore became 33 hours and left sessions waiting on commands long after Riptide considered them inactive.Historical session events remain readable because persisted tool-call parameters are stored as unknown data and are not re-executed during replay.
Validation
bun --cwd packages/fold-agent test test/Tools/BashTool.vi.test.ts(21 passed)bun run --cwd packages/fold-agent typecheckbun run format:check