Add A5 sin/cos and integer vdiv PTODSL SoftLib implementations - #1193
Merged
Conversation
Zhendong404
force-pushed
the
codex/issue-1181
branch
from
August 9, 2026 01:59
4a5b6d7 to
4cdd70d
Compare
Zhendong404
force-pushed
the
codex/issue-1181
branch
from
August 10, 2026 02:03
8fdba68 to
b999371
Compare
Zhendong404
force-pushed
the
codex/issue-1181
branch
from
August 10, 2026 10:33
c5ccf69 to
023c5ad
Compare
Contributor
|
#1181 在本地初步验证通过 |
Zhendong404
force-pushed
the
codex/issue-1181
branch
from
August 11, 2026 13:25
023c5ad to
4c52ba8
Compare
KurrinQu
reviewed
Aug 13, 2026
| return reduced, quadrant | ||
|
|
||
|
|
||
| def sin_f32_soft(value): |
Collaborator
There was a problem hiding this comment.
当前实现和ASC的接口功能和精度接近,但不是逐比特一致。对于大角度输入,ASC功能和精度相对完整些。后续有场景需要时,可以作为参考。
A3 板测失败
日志尾部 |
A5 板测失败
失败用例
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #993
Fixes #1181
Adds the unified A5 PTODSL SoftLib path for operations that cannot rely on the released BiSheng lowering. The late materialization pass now expands SIMT sin/cos and signed i32 vector vdiv after the main VPTO/TileLib optimizations, then the normal inline pass lowers the DSL helpers.
The i32 division helper is reused by the A5 tdiv, tdivs, and tcolexpanddiv TileLib templates and has lit, materialization, and tilelib-st precision coverage.
Validation: