Repository navigation
feat(mobile): Linear ticket client + fix OAuth URL scheme regression - #10
Merged
Merged
Conversation
mobile/project.yml's targets.HyperGit.info.properties did not declare CFBundleURLTypes, so `xcodegen generate` treats App/Info.plist as a generated artifact and silently drops any key not listed there. This clobbered the manually-added hypergit:// URL scheme registration on every regeneration (including CI, which runs xcodegen generate on every mobile/** push per .github/workflows/mobile.yml). OAuthService.swift uses ASWebAuthenticationSession with callbackURLScheme: "hypergit" for both GitHub and Linear OAuth (redirect URI hypergit://oauth-callback). Per Apple's documented pattern, the scheme must be registered in CFBundleURLTypes even when using ASWebAuthenticationSession, or iOS has no way to route the callback back into the app — the OAuth flow breaks silently on-device and in CI, with nothing currently asserting the callback works. Adds CFBundleURLTypes to project.yml's info.properties so the generated Info.plist keeps the registration on every future regeneration. Verified with xcodegen 2.45.4: regenerating with the fix reproduces the committed Info.plist's CFBundleURLTypes block byte-for-byte; reverting the fix and regenerating strips the block (negative control), confirming the causal link. Blocks shipping the mobile Linear client work tracked in #3 (OAuth must work before that PR ships). Refs #3 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 7, 2026
4 tasks done
alex-mextner
added a commit
that referenced
this pull request
Aug 7, 2026
Brings in PR #12 (CI fix: pin apple-actions/import-codesign-certs to a commit SHA) and PR #10 (Linear ticket client + OAuth URL scheme fix) so this branch's CodeQL check can pass before merging. Resolved conflicts in HyperGitApp.swift, TicketsView.swift, AppStore.swift, and ModelsTests.swift by keeping this branch's fetchTickets/TicketSourceOutcome refactor, which already carries every behavior main added (partial-results handling, auth-failure differentiation) plus this branch's own stale-cache banner tracking (issue #4). Refs #4
This was referenced Aug 8, 2026
alex-mextner
added a commit
that referenced
this pull request
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async/awaitLinear GraphQL client (LinearClient.swift) behind aprotocol: cursor-based pagination beyond the first page, and typed GraphQL error
surfacing instead of silent truncation. Covered by
LinearClientTests.swift(7tests) using an injected transport — no live network calls.
mobile/App/Info.plistsilently lost itsCFBundleURLTypes(OAuthhypergit://URL scheme) block on everyxcodegen generaterun. Root cause:mobile/project.yml'stargets.HyperGit.info.propertiesdidn't declareCFBundleURLTypes, and XcodeGentreats
Info.plistas a generated artifact — any key missing frominfo.propertiesgets dropped on regeneration. This silently broke OAuth on everylocal rebuild and in CI (
.github/workflows/mobile.ymlrunsxcodegen generateonevery
mobile/**push/PR), sinceOAuthService.swiftusesASWebAuthenticationSessionwithcallbackURLScheme: "hypergit"for both GitHuband Linear OAuth, and iOS needs that scheme registered to route the callback back
into the app.
Test plan
swift build— clean build, no errors.swift test— 31/31 tests passing across 4 suites (LinearClient GraphQLtickets, Models, OAuth config, GitHubClient parsing + pagination).
xcodegen generate(version 2.45.4) verified end-to-end: regeneratingInfo.plistwith theproject.ymlfix reproduces theCFBundleURLTypesblock byte-for-byte identical to the committed file. A negative control
(temporarily reverting the fix and regenerating) reproduces the original bug —
the block disappears — confirming the causal link.
review diff) run on the fix; findings concerned thepre-existing OAuth implementation (PKCE/state validation, scheme naming), not
this diff, and were verified against
OAuthService.swift— the fix isconfirmed necessary and correct for
ASWebAuthenticationSession's documentedURL-scheme-registration requirement.
Closes #3
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com