Integration test: reconfig app org by gengur · Pull Request #285 · hyperledger/fabric-x

gengur · 2026-08-25T10:06:53Z

Type of change

Integration test

Description

Submit a reconfig TX on the orderer+committer docker network.

Related issues

#280 (comment))

Copilot

Pull request overview

Adds an end-to-end integration test that spins up the orderer+committer Docker Compose network and submits a channel reconfiguration transaction to add an application org, verifying the config update is committed and delivered.

Changes:

Added a new Go integration test covering reconfig (add peer-org-1) and post-reconfig block delivery verification.
Added a dedicated Armageddon network config (arma_config.yaml) for the integration test network topology.
Updated Docker Compose and Go module dependencies to support the new test setup (notably testcontainers compose usage).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.

File	Description
integration/test/reconfig_app_org_test.go	New integration test that sets up the network, submits config update, and verifies delivery/commit behavior.
integration/test/ordererconfig/arma_config.yaml	New network configuration used by the integration test.
integration/test/docker-compose.yaml	Adjusted committer/loadgen/explorer commands/formatting to align with the test’s compose flow.
go.mod / go.sum	Dependency updates (incl. testcontainers-go upgrade) required by the new integration test dependencies.

Suppressed comments (1)

integration/test/reconfig_app_org_test.go:258

After removing the duplicate utils import, this call should use the remaining utils import name (ordererutils) so the code compiles.

	knownCertPaths, err := utils.PemFilesFromDir(knowncertsDir)

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

cendhu · 2026-09-02T11:51:25Z

          EXPLORER_IMAGE: ${{ steps.images.outputs.explorer_image }}
          FABRIC_X_BIN: ${{ github.workspace }}/integration/test/.build/fabric-x/bin
          SKIP_CLEANUP_PROMPT: "1"
+          ENABLE_EXPLORER: "false"


why do we disable it? we need to ensure it's compatibility too.

I inserted it by mistake and have restored it

cendhu · 2026-09-02T11:52:39Z

+EXPLORER_DIR="${BUILD_DIR}/fabric-x-block-explorer/docker/images/release"
 checkout_source "${EXPLORER_REPO}" "${EXPLORER_REF}" "${EXPLORER_DIR}" "${EXPLORER_LOCAL_PATH:-}" "fabric-x-block-explorer"

 EXPLORER_IMAGE="localhost/${EXPLORER_IMAGE_NAME}:${EXPLORER_REF}"
 echo "Building ${EXPLORER_IMAGE_NAME} image from ${EXPLORER_DIR}..."
-docker build -t "${EXPLORER_IMAGE}" "${EXPLORER_DIR}"
+docker build -t "${EXPLORER_IMAGE}" "${EXPLORER_DIR}" || {
+  echo "WARNING: ${EXPLORER_IMAGE_NAME} image build failed, continuing without it (setting ENABLE_EXPLORER=false)"
+  export ENABLE_EXPLORER=false
+}


not sure why we are changing these?

The Docker build for the Explorer image fails because there is no Dockerfile in the project root. This is the workaround

cendhu · 2026-09-02T11:53:44Z

+      - "4001:4001" # Sidecar deliver (loadgen connects here)
+      - "7001:7001" # Coordinator gRPC
+      - "2114:2114" # Sidecar Prometheus metrics
+      - "2115:2115" # Verifier Prometheus metrics
+      - "2116:2116" # VC Prometheus metrics (verified in Step 9)
+      - "2117:2117" # Query Prometheus metrics
+      - "2119:2119" # Coordinator Prometheus metrics


are these intendation changes necessary?

restored the original version

tock-ibm · 2026-09-02T12:06:23Z

          EXPLORER_IMAGE: ${{ steps.images.outputs.explorer_image }}
          FABRIC_X_BIN: ${{ github.workspace }}/integration/test/.build/fabric-x/bin
          SKIP_CLEANUP_PROMPT: "1"
+          ENABLE_EXPLORER: "false"


This needs to be in the other workflow

tock-ibm · 2026-09-02T12:24:10Z

+          ORDERER_IMAGE: ${{ steps.images.outputs.orderer_image }}
+          COMMITTER_IMAGE: ${{ steps.images.outputs.committer_image }}
+          SKIP_CLEANUP_PROMPT: "1"
+        run: ./integration/test/run-reconfig-test.sh


Lets first run a no-op command, like print the arguments and a message, to verify all steps up to here are ok. Then, we merge only the manual flow, and after it is in main, we point it to the actual test.
IE first a no-op ./integration/test/run-reconfig-test.sh

…#293) #### Type of change Integration test #### Description Add the reconfiguration workflow #### Related issues issue #285 Signed-off-by: Gurevich.Genady <genadyg@il.ibm.com>

Signed-off-by: Gurevich.Genady <genadyg@il.ibm.com>

gengur marked this pull request as draft August 25, 2026 10:07

gengur changed the title ~~Integration test: reconfig app org #280~~ Integration test: reconfig app org Aug 25, 2026

tock-ibm requested a lite review from Copilot August 25, 2026 13:12

Copilot started reviewing on behalf of tock-ibm August 25, 2026 13:13 View session

Copilot AI reviewed Aug 25, 2026

View reviewed changes

gengur force-pushed the reconfig_app_org branch 12 times, most recently from c12d76e to 93aafe3 Compare August 26, 2026 15:11

tock-ibm reviewed Aug 30, 2026

View reviewed changes

Comment thread Makefile Outdated

gengur force-pushed the reconfig_app_org branch 2 times, most recently from 1443901 to 7aa0096 Compare August 31, 2026 06:02

gengur requested a review from tock-ibm August 31, 2026 06:03

gengur force-pushed the reconfig_app_org branch 9 times, most recently from ab9cc19 to 67c9fdc Compare September 1, 2026 09:39

gengur force-pushed the reconfig_app_org branch 2 times, most recently from 3359adf to 7c5e092 Compare September 2, 2026 05:28

cendhu reviewed Sep 2, 2026

View reviewed changes

tock-ibm reviewed Sep 2, 2026

View reviewed changes

gengur mentioned this pull request Sep 2, 2026

Integration test: reconfig app org (add the reconfiguration workflow) #293

Merged

gengur force-pushed the reconfig_app_org branch from 7c5e092 to 9604b6f Compare September 2, 2026 13:24

gengur force-pushed the reconfig_app_org branch from 9604b6f to d6fe6df Compare September 3, 2026 12:43

gengur marked this pull request as ready for review September 3, 2026 12:59

gengur requested a review from tock-ibm September 3, 2026 12:59

gengur force-pushed the reconfig_app_org branch 4 times, most recently from f64bed5 to 0fc57ba Compare September 3, 2026 13:20

Integration test: reconfig app org hyperledger#280

b768fc1

Signed-off-by: Gurevich.Genady <genadyg@il.ibm.com>

gengur force-pushed the reconfig_app_org branch from 0fc57ba to b768fc1 Compare September 3, 2026 13:22

Uh oh!

Conversation

gengur commented Aug 25, 2026

Type of change

Description

Related issues

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants