Repository navigation
feat: API rate limit - #348
Merged
Merged
Conversation
supun-io
force-pushed
the
201-rate-limit-the-subscribe-endpoint
branch
from
November 20, 2025 14:18
3c69466 to
25a3932
Compare
supun-io
reviewed
Nov 20, 2025
Nadil-K
requested changes
Oct 8, 2026
- Port console rate limiting to ConsoleAuthResults (cloud API auth from #461): sessions are limited per user, product API keys and cloud tokens per auth source. Skip auth-bypassed paths like /api/console/init. - Keep main's test issue limit (10/hour per newsletter) as a stricter limit on top of the general one; its headers win on that endpoint. - Bring main's test issue rate limit tests along. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nolab0
force-pushed
the
201-rate-limit-the-subscribe-endpoint
branch
from
October 23, 2026 12:50
5ff57ce to
2ecc62d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Nadil-K
requested changes
Oct 26, 2026
Nadil-K
left a comment
Nadil-K
left a comment
Member
There was a problem hiding this comment.
- Use
IpService::resolveIp()inFormController::subscribe()(it still saves the CF IP)
| $this->assertResponseHeaderSame('X-RateLimit-Remaining', '99'); | ||
| } | ||
|
|
||
| public function test_subscribe_endpoint_applies_per_minute_email_rate_limit(): void |
Member
There was a problem hiding this comment.
- move these public API tests to
tests/Api/Public/RateLimitTest.php
Nadil-K
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #201
Important: we must update the webhook URL in hyvor Relay in Production