Repository navigation
a11y(palette-react): ARIA/focus tests, named+announced text step, hidden-vs-disabled rule - #66
Merged
Merged
Conversation
… name and announce picker text step; record hidden-vs-disabled rule Part of #64 (palette ARIA test, hidden vs disabled). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s; correct hidden-vs-disabled rule Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 13, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #64 (items: palette ARIA test, hidden vs disabled).
palette.a11y.test.tsx: pins the APG combobox roles, accessible names,aria-activedescendant, and focus hand-off (list → picker chain → Escape; list → host form → cancel).role=alert+aria-describedby+aria-invalid).acture-palette-designskill: records the per-surface rule (palette hides whencontextis passed; menus show disabled viaaria-disabled; AI/MCP should hide, not yet implemented) and the a11y contract.when), palette-react: aria-activedescendant is not published for the initial highlighted option (cmdk 1.1.1) #68 (cmdk initialaria-activedescendant).Adversarial review (fresh Opus subagent): FIX FIRST on 5 confirmed points (false claim that MCP/AI hide unavailable commands; palette hiding needs
context; cmdkItemoverwrites a hostaria-disabledso usedisabled; wrong claim aboutdisabledand screen-reader browse; accessible name must match the visible description). All fixed in the second commit, with a new Label-in-Name test. Tests non-vacuous per the reviewer.🤖 Generated with Claude Code