Repository navigation
feat: azuredol.substore(store, key) through the caller's wrappers (#6) - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6.
azuredol.substore(store, 'a/')[k] == store['a/'+k]through any wrapper stack: a bareContainerStore(not overriding_id_of_key) gets the cheap server-scoped leaf sub-store; anything wrapped (instance wrappers, codec classes, key-mapping subclasses) gets aKeyCodecs.prefixed(key)view of the caller's own store (lists the wrapped scope, keeps keys underkey). Opaque layers refused; keys with a leading/or//refused (the leaf would normalise them differently).dol>=0.3.75required.store['sub/']is untouched; deprecating it is the decision issue #9 (recommendation: keep). Docs updated; Azurite tests not run (no server), mock tests added.Adversarial review (Opus): confirmed dol floor too low (older dol names the wrong blob), cheap path wrong for a key-mapping subclass, edge keys disagreeing between paths: all fixed with tests; wrapped views'
.prefix/.walk_ids()describe the parent (documented, usewalk).🤖 Generated with Claude Code