Repository navigation
feat: on_overwrite(policy, same) (#161) - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
Adds
dol.on_overwrite(store, *, policy="warn"|"raise"|"overwrite"|callable, same=..., stacklevel=3): an overwrite policy for stores (class, instance or decorator factory), built on awrap_kvspreset. Writing asamevalue is silent (defaultsame: identity, then==, and an ambiguous or raising==counts as different). Additive API only.Review (two rounds, fresh Opus agents). Round 1 verdict "merge after fixes": default
==crashed on array-like values; hardcoded stacklevel; brand'sRegistrycouldn't adopt it (no custom message/exception). Applied: safe defaultsame,stacklevelkwarg, callable policy as strategy, shared_existing_if_differenthelper withmk_confirm_overwrite_preset(behaviour unchanged),policy="overwrite"returns the store unwrapped,OVERWRITE_POLICIES/preset factory made private, docstring notes (per-write read, not thread-atomic, delete-then-write bypasses "raise"). Round 2: OK to land, no blockers; two non-blocking nits left (redundant policy re-resolve, one duplicated test).Tests: full
pytest832 passed, 2 skipped locally.