Repository navigation
Stop ExecSection from mutating the shared kwargs input spec - #44
Merged
Merged
Conversation
_feed_kwargs_input_spec assigned into inputs["kwargs"]["inputs"], which is the dict held by the convention default, so each section leaked its sibling input specs into every section built after it. Build new dicts instead and use self.inputs when making the input element specs. Fixes #39 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
ExecContainerBase._feed_kwargs_input_specassigned intoself.inputs["kwargs"]["inputs"], which is the dict held by the convention default (e.g. streamlitfront'sDFLT_CONVENTION_DICT), so every section leaked its sibling input specs into every later section in the process. It now builds new dicts, and__init__passesself.inputs(not the caller'sinputs) tomk_input_element_specs.Regression test:
tests/test_exec_section_spec_isolation.pybuilds two sections from one shared spec and checks the sharedkwargsentry is untouched (fails on master).streamlitfront tests pass against this branch (17 passed).
🤖 Generated with Claude Code