Repository navigation
Add DefaultPlaceholder and is_placeholder_default; InstanceAttrDefault is one - #121
Merged
Merged
Conversation
…t is one A methodize(default_from=...) signature default is an InstanceAttrDefault marker, not a value. Consumers that serialize signature defaults (front forms, py2http OpenAPI) should skip it as they skip NotSet; is_placeholder_default is the one predicate for both. Test: a JSON dump of a methodized function's Sig defaults. Closes #120 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
A
methodize(..., default_from=...)param's signature default is anInstanceAttrDefaultmarker (self.attr), not a value: its value depends on the instance, which a form or schema generator does not have. Decision: no serialization hook; consumers treat it as "no default", exactly as they treatNotSet.i2.DefaultPlaceholder: base class for signature defaults that stand for a value rather than being one.InstanceAttrDefaultsubclasses it.i2.is_placeholder_default(x):NotSetor aDefaultPlaceholder; the one predicate consumers need.Sig(...).defaultsfails raw and succeeds with placeholders skipped.Additive only;
is_not_setis unchanged. Consumers switch in follow-ups (front, py2http).🤖 Generated with Claude Code