Repository navigation
Make PathFormatStore doctest hermetic (no /tmp walk) - #99
Merged
Merged
Conversation
…alk) Fixes #98 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…lean up temp dirs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98.
The doctest's
PathFormatStore(path_format=rootdir_2 + '{}.txt')had no separator, so the store root was the system temp dir ands != ssiterated all of /tmp (20+ min on a busy machine). Both roots are now freshtempfile.mkdtemp() + os.sepdirs, removed at the end. Suite: 79 passed, 1 skipped in ~5s.Adversarial review (fresh Opus subagent): sound, no blockers. Two findings, both fixed: the second set of files was written to the first dir (so
s != sspassed trivially against an empty dir) and temp dirs were left behind.🤖 Generated with Claude Code