Repository navigation
feat: sync_to subdir with spaces/metacharacters via rsync -s (#12 item 2) - #17
Merged
Merged
Conversation
…3.2.4 (-s) (#12) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…past the confinement check); don't cache a failed version probe Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 2 of #12.
subdiroutside[\w./@%+=:,-]was always refused (old rsyncs split the remote path in a shell). With local rsync >= 3.2.4 (local_rsync_version()) such a subdir is now sent with-s; control characters and rsync wildcards (* ? [ ]) are still refused; older rsync keeps the ValueError (naming the version). Plain subdirs are unchanged.Adversarial review (Opus): confirmed a regression that reopened the #13 symlink escape: with the charset relaxed,
subdir='ln[k]'/'*'passed the check on the literal name and the remote rsync expanded the glob through a link; fixed by refusing wildcards (regression tests with an outside symlink). Also fixed:v3.2.7-style version strings, a failed version probe being cached forever. Refuted: injection via;,$(), backticks, quotes, leading-,:,..through globs, backslashes. Real-sshd tests formy dir,a;b $x,quote'd, non-ASCII.Item 1 of #12 stays blocked on a dol scope probe (i2mint/dol#122); item 3 is #16. #12 stays open for item 1.
🤖 Generated with Claude Code