Repository navigation
Skip selenium e2e helpers at collection when their deps are missing (#24) - #25
Merged
Merged
Conversation
…error-safe (#24) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24.
streamlitfront/tests/common.pyanduse_case_test_old.pyimport selenium/webdriver_manager/strand (listed intests/test_requirements.txt, not installed by CI or the dependents gate), so the gate'spytest --doctest-modulesdied at collection (2 errors). The packagetests/conftest.pynow setscollect_ignorefor them when those deps (orfront.tests.test_use_case) are not importable. With the deps installed nothing is ignored.Verified from the package folder (where the gate collects): master 2 collection errors, branch 20 passed.
Adversarial review (fresh Opus): sound, no blocking problems. Two notes taken: the importable check now covers only the real e2e deps (selenium, webdriver_manager, strand, and front.tests.test_use_case for the old test) and is ImportError-safe. Accepted trade-off: a genuine import break in those two files is skipped when a dep is missing.
🤖 Generated with Claude Code