Repository navigation
install-system-deps: run installer from action checkout, not PyPI (#152 follow-up) - #155
Merged
Merged
Conversation
…, not a PyPI wheel (#152)
… needs packaging); real test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the root cause behind mixing run 40380164969 still timing out at 300 s after #153 (see #152).
Root cause:
actions/install-system-depsranpip install wads(unpinned, from PyPI) and then the installer from that wheel, so the code that ran was decoupled from the ref the reusable workflow was called at. The mixing run started 2 min after 0.2.57 hit PyPI and got 0.2.56 (log: "timeout: 300s per command", noDPkg::Lock::Timeout, no process-group kill). Any fix toinstall_system_deps.pymerged to master was therefore live only after PyPI propagation, and pinned callers never got it.Change: drop the pip step; run
python3 -m wads.install_system_depswithPYTHONPATH=$GITHUB_ACTION_PATH/../..(the module is stdlib-only,wads/__init__is light, same pattern asexport-ci-env). Test pins it. Doc string fixed (900 for ffmpeg).