Repository navigation
Actions run their scripts from their own checkout (#156) - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156.
read-ci-config,set-env-varsandbuild-distnow run their script by path from the action's own checkout ($GITHUB_ACTION_PATH/../../wads/scripts/...), asexport-ci-envandinstall-system-depsalready do. Thepip install 'wads>=0.1.48'steps are gone. The scripts loadwads/ci_config.pythrough a small stdlib-only loader (wads/scripts/_checkout_import.py) so they never import thewadspackage (which needs third-party deps) or a stale wheel. Backward compatible:python -m wads.scripts.*still works.Tests: new
test_actions_run_from_checkout.py(no pip install in the actions; scripts run underpython -I [-S]without the wads package);test_action_definitionsupdated to the path form. Full suite green excepttest_stub_transport_default::test_rerendering_json_stub_content_converts_it_to_named, which fails identically on master (macOSFile name too long, unrelated).Review (fresh Opus adversarial): found that the old pip install silently supplied
packaging, so the #59 test-extra warning would have vanished; fixed by installingpackagingin read-ci-config, with a test that asserts the warning and outputs underpython -I. Also fixed stale comments, strengthened tests. Declined as not worth it: sys.path tidy-up (harmless), wider refactor (loader is 28 lines, no bloat). Deferred nit: docs snippets in wads/scripts/README.md still show-mform.