Repository navigation
feat(build): allow release-optimized builds with the dev app identity - #141
Merged
Merged
Conversation
OPEN_COMPUTER_USE_APP_VARIANT=dev keeps the dev bundle identifier, name and variant with release optimization, and does not remove neighboring release or legacy bundles. Automatic Locked Use packaging stays with the release identity; an explicit request with a dev release build is refused. Unset, the script is unchanged.
Owner
Author
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #138 by @chidev, preserving the original commit. The organization fork rejects maintainer pushes, so the reviewed updates are published from this repository.
OPEN_COMPUTER_USE_APP_VARIANT=dev ./scripts/build-open-computer-use-app.sh releasebuilds optimized code with the Dev bundle identity/name. Explicit Dev builds preserve neighboring release/legacy bundles. Automatic Locked Use embedding is disabled for this combination, and explicitly requesting incompatible release Locked Use components fails before building.The override is limited to direct app builds. Release/npm packaging and plugin installation reject an inherited override before cleanup or copying, preventing an older release bundle beside a newly built Dev bundle from being accidentally selected. Existing behavior with the variable unset is preserved.
Validation:
python3 scripts/tests/macos-app-variant-smoke.py --signed.No Swift runtime changes, installed-app changes, permission changes or release publication.