refactor: delete the dead orchestration layer and the broken pr command - #29
Merged
Merged
Conversation
The July audit found roughly a third of core unreachable from any runtime path: nothing in the hook-driven product creates Jobs or Locks, dispatch can never match a hook-created session (they always carry a currentRunId), and the machinery was kept alive only by its own tests. Keeping it meant real maintenance cost — the lock-expiry SQL was broken, and `agentops pr` couldn't create a PR at all (gh rejects the --json flag it passed). Removed: - core: job.ts, dispatcher.ts, orchestrator.ts, coordination.ts, the Job/ResourceLock types, JobStatus/JobPriority/LockType enums, JobId/LockId brands, EventCategory.Job, and the job.* event types - db: jobs.ts, locks.ts, the jobs/locks tables (schema + migrations), and the job-event seed rows. Existing databases keep their orphaned jobs/locks tables; they are inert and harmless - cli: `job`, `lock`, `dispatch`, and `pr` commands; createPR/ addPRComment/createCheckRun in github.ts (link's read-only helpers stay); the job branch of `events` colorization - web: job entries in the event-type union, category filter, badge colors, and the ActivityFeed/EventCard links that pointed at the long-removed /jobs pages Docs updated (CLAUDE.md package map + commands, CHANGELOG "Removed"). Test suite drops from 1,366 to 1,256 — the difference is the dead layer's own tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The July audit found roughly a third of core unreachable from any runtime
path: nothing in the hook-driven product creates Jobs or Locks, dispatch
can never match a hook-created session (they always carry a currentRunId),
and the machinery was kept alive only by its own tests. Keeping it meant
real maintenance cost — the lock-expiry SQL was broken, and
agentops prcouldn't create a PR at all (gh rejects the --json flag it passed).
Removed:
Job/ResourceLock types, JobStatus/JobPriority/LockType enums,
JobId/LockId brands, EventCategory.Job, and the job.* event types
and the job-event seed rows. Existing databases keep their orphaned
jobs/locks tables; they are inert and harmless
job,lock,dispatch, andprcommands; createPR/addPRComment/createCheckRun in github.ts (link's read-only helpers
stay); the job branch of
eventscolorizationcolors, and the ActivityFeed/EventCard links that pointed at the
long-removed /jobs pages
Docs updated (CLAUDE.md package map + commands, CHANGELOG "Removed").
Test suite drops from 1,366 to 1,256 — the difference is the dead
layer's own tests.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com