Bumped Composer version - #3342
Open
mnocon wants to merge 1 commit into
Open
Conversation
Preview of modified filesPreview of modified Markdown: |
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
August 5, 2026 15:43
Summary
|
adriendupuis
approved these changes
Aug 6, 2026
adriendupuis
left a comment
adriendupuis
left a comment
Contributor
There was a problem hiding this comment.
It's already OK and my comment is a bit out of scope so it could be for another time.
So I approve while letting my thought for a general improvement of this sentence that is used in a lot of other places in this page.
Comment on lines
+256
to
+257
| If you see a "+" next to the product version, it indicates a recommended version or higher within the same major release. | ||
| For example, "1.18+" means any 1.x version equal to or higher than 1.18, but not 2.x. |
Contributor
There was a problem hiding this comment.
I know this sentence is all over the place and if I ask for change here, it should be updated elsewhere, sorry for that. Maybe an included snippet like docs/snippets/update/db/db_backup_warning.md and others?
This "recommended version" then "or higher" bothers me. It might sounds like higher is possible but not the one recommended.
Suggested change
| If you see a "+" next to the product version, it indicates a recommended version or higher within the same major release. | |
| For example, "1.18+" means any 1.x version equal to or higher than 1.18, but not 2.x. | |
| If you see a "+" next to the product version, it indicates a recommended version range, a minimal version or higher within the same major release. | |
| The higher is more recommended. | |
| For example, "1.18+" means any 1.x version equal to or higher than 1.18, but not 2.x. | |
| So the latest 1.x is recommended but 1.18 fits the requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target: 4.6, 5.0, 6.0
Feedback received on Slack - we should promote the latest Composer version (2.10 is available)