Skip to content

CI: toolchain from rust-toolchain.toml - #3

Merged
ilnmtlbnm merged 1 commit into
mainfrom
ci-toolchain-from-file
Oct 7, 2026
Merged

ilnmtlbnm merged 1 commit into
mainfrom
ci-toolchain-from-file

Conversation

@ilnmtlbnm

Copy link
Copy Markdown
Member

Summary

  • GitHub runners ship rustup, which reads rust-toolchain.toml (channel, targets, components) on the first cargo/rustc call. This repo's rust-toolchain.toml already pins the channel and declares the targets/components the workflow needs, so pinning the toolchain a second time via the dtolnay/rust-toolchain action step is redundant and is the only place the Rust version would need bumping twice.
  • Replaces the dtolnay/rust-toolchain@1.99.0 step with rustup show active-toolchain, which installs (and logs) the toolchain from rust-toolchain.toml on first use. Rust version bumps now happen in rust-toolchain.toml alone.

Test plan

  • Could not run GitHub Actions before merge; pushing this branch alone does not trigger the workflow (push: is limited to branches: [main]). Opening this PR triggers the workflow via its pull_request: branches: [main] trigger — see the checks on this PR.

@ilnmtlbnm
ilnmtlbnm merged commit f818e10 into main Oct 7, 2026
2 checks passed
@ilnmtlbnm
ilnmtlbnm deleted the ci-toolchain-from-file branch October 9, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant