Repository navigation
Keep +simd128 in the wasm build: pass extra flags with cargo --config - #14
Merged
Merged
Conversation
RUSTFLAGS as an env var replaces .cargo/config.toml's target rustflags instead of adding to it, so the leak-check remap flag was silently dropping +simd128 from both wasm builds since build.sh was added. Pass the remap flag through cargo's --config instead, which merges with the config file's rustflags array. wasm-pack 0.14's extra-args parser mishandles "--features <name> -- <extra>" (the -- separator and everything after it get swallowed into --features's value list), so the --config has to go right after --features with no -- separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/build.shsetRUSTFLAGSfor the path-remap flags.RUSTFLAGSreplaces therustflagsin.cargo/config.tomlinstead of adding to them, so the wasm build lost+simd128. The remap flags now go throughcargo --config, which merges with the config file.