frist - #512
Merged
ignatandrei merged 4 commits intoJul 16, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds the 277th Roslyn source generator example, Bennewitz.Ninja.AutoVersioning, with metadata, documentation, a runnable .NET sample, walkthrough assets, and updates to repository and website catalogs. ChangesBennewitz AutoVersioning example
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Project as InfoPrj.csproj
participant Generator as Bennewitz.Ninja.AutoVersioning
participant Sources as Generated source files
participant App as Program.cs
Project->>Generator: Supply versioning and assembly properties
Generator->>Sources: Generate assembly metadata and DirectoryBuildInfo
App->>Sources: Read DirectoryBuildInfo.BuildRelease
Sources-->>App: Provide generated build value
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new RSCG example for Bennewitz.Ninja.AutoVersioning and wires it into the v2 data pipeline + documentation site so it appears in lists, category pages, exports, and counts.
Changes:
- Introduces a new example project (
InfoPrj) demonstratingDirectoryBuildInfo.BuildRelease. - Adds the generator metadata and documentation pages/exports so the site lists the new example (277 total).
- Updates “latest update” dates and category/author indexes to include the new entry.
Reviewed changes
Copilot reviewed 21 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| v2/RSCGExamplesData/GeneratorDataRec.json | Adds the generator to the core v2 generator registry data. |
| v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/video.json | Adds the scripted video steps for the example. |
| v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/src/InfoPrj/Program.cs | Minimal runtime demo printing the generated build version constant. |
| v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/src/InfoPrj/InfoPrj.csproj | Adds the package reference and MSBuild properties used by the generator. |
| v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/src/InfoPrj.slnx | Solution wrapper for the example project. |
| v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/readme.txt | Captures the upstream readme content for the example. |
| v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/nuget.txt | Short description used by the site/docs generator. |
| v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/description.json | Metadata describing how the site should present the example. |
| v2/rscg_examples_site/static/exports/RSCG.json | Adds the new entry to the exported JSON list. |
| v2/rscg_examples_site/src/components/HomepageFeatures/index.js | Updates the homepage example count (276 → 277). |
| v2/rscg_examples_site/docs/RSCG-Examples/index.md | Updates counts and links for the new example in the category list. |
| v2/rscg_examples_site/docs/RSCG-Examples/Bennewitz.Ninja.AutoVersioning.md | Adds the dedicated documentation page for the generator. |
| v2/rscg_examples_site/docs/indexRSCG.md | Updates the chronological index and counts (276 → 277). |
| v2/rscg_examples_site/docs/Categories/EnhancementProject.md | Updates category count and inserts the new generator into the list. |
| v2/rscg_examples_site/docs/Categories/_PrimitiveEnhancementProject.mdx | Updates the category primitive list used for cross-linking. |
| v2/rscg_examples_site/docs/Authors/Brian_Bennewitz.md | Adds an author index page for the new generator author. |
| v2/rscg_examples_site/docs/about.md | Updates the “about” page count (276 → 277). |
| v2/Generator/all.csv | Adds the generator to the CSV used to drive generation/exports. |
| v2/.tours/Bennewitz.Ninja.AutoVersioning.tour | Adds a VS Code CodeTour for the new example. |
| README.md | Updates repo-level counts and “Latest Update” date and adds the new entry. |
| later.md | Updates “Latest Update” date. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "show": true | ||
| }, | ||
| { | ||
| "ID":"Bennewitz.Ninja.AutoVersioning", |
Comment on lines
+35
to
+36
| {"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/Bennewitz.Ninja.AutoVersioning#download-example-net--c-", | ||
| SpeakTest=" "}, |
Comment on lines
+14
to
+17
| "file": "rscg_examples/Bennewitz.Ninja.AutoVersioning/src/InfoPrj/Program.cs", | ||
| "description": "File Program.cs \r\n>> dotnet run --project rscg_examples/Bennewitz.Ninja.AutoVersioning/src/InfoPrj/InfoPrj.csproj ", | ||
| "pattern": "this is the code" | ||
| } |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
v2/rscg_examples_site/docs/indexRSCG.md (1)
23-23: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove space inside link text.
There is a trailing space inside the Markdown link brackets that triggers a markdownlint warning.
🧹 Proposed fix
-|277| [Bennewitz.Ninja.AutoVersioning by Brian Bennewitz ](/docs/Bennewitz.Ninja.AutoVersioning)|2026-07-04 => 04 July 2026 | [EnhancementProject](/docs/Categories/EnhancementProject) | +|277| [Bennewitz.Ninja.AutoVersioning by Brian Bennewitz](/docs/Bennewitz.Ninja.AutoVersioning)|2026-07-04 => 04 July 2026 | [EnhancementProject](/docs/Categories/EnhancementProject) |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@v2/rscg_examples_site/docs/indexRSCG.md` at line 23, Remove the trailing space from the Markdown link text for “Bennewitz.Ninja.AutoVersioning” in the project listing, keeping the link target and surrounding table content unchanged.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/video.json`:
- Around line 35-36: Correct the malformed property definition in the JSON
object by using valid JSON syntax: quote the property name and separate it from
its value with a colon instead of an equals sign. Preserve the existing property
value and surrounding object structure.
---
Nitpick comments:
In `@v2/rscg_examples_site/docs/indexRSCG.md`:
- Line 23: Remove the trailing space from the Markdown link text for
“Bennewitz.Ninja.AutoVersioning” in the project listing, keeping the link target
and surrounding table content unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7fcba257-6f2d-44f9-93b6-0651cbdee975
⛔ Files ignored due to path filters (3)
v2/Generator/all.csvis excluded by!**/*.csvv2/rscg_examples_site/static/exports/RSCG.xlsxis excluded by!**/*.xlsxv2/rscg_examples_site/static/sources/Bennewitz.Ninja.AutoVersioning.zipis excluded by!**/*.zip
📒 Files selected for processing (20)
README.mdlater.mdv2/.tours/Bennewitz.Ninja.AutoVersioning.tourv2/RSCGExamplesData/GeneratorDataRec.jsonv2/rscg_examples/Bennewitz.Ninja.AutoVersioning/description.jsonv2/rscg_examples/Bennewitz.Ninja.AutoVersioning/nuget.txtv2/rscg_examples/Bennewitz.Ninja.AutoVersioning/readme.txtv2/rscg_examples/Bennewitz.Ninja.AutoVersioning/src/InfoPrj.slnxv2/rscg_examples/Bennewitz.Ninja.AutoVersioning/src/InfoPrj/InfoPrj.csprojv2/rscg_examples/Bennewitz.Ninja.AutoVersioning/src/InfoPrj/Program.csv2/rscg_examples/Bennewitz.Ninja.AutoVersioning/video.jsonv2/rscg_examples_site/docs/Authors/Brian_Bennewitz.mdv2/rscg_examples_site/docs/Categories/EnhancementProject.mdv2/rscg_examples_site/docs/Categories/_PrimitiveEnhancementProject.mdxv2/rscg_examples_site/docs/RSCG-Examples/Bennewitz.Ninja.AutoVersioning.mdv2/rscg_examples_site/docs/RSCG-Examples/index.mdv2/rscg_examples_site/docs/about.mdv2/rscg_examples_site/docs/indexRSCG.mdv2/rscg_examples_site/src/components/HomepageFeatures/index.jsv2/rscg_examples_site/static/exports/RSCG.json
Comment on lines
+35
to
+36
| {"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/Bennewitz.Ninja.AutoVersioning#download-example-net--c-", | ||
| SpeakTest=" "}, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Fix invalid JSON syntax.
The property definition uses an equals sign and an unquoted key, which completely breaks JSON parsing.
🐛 Proposed fix
{"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/Bennewitz.Ninja.AutoVersioning#download-example-net--c-",
- SpeakTest=" "},
+ "SpeakTest": " "},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| {"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/Bennewitz.Ninja.AutoVersioning#download-example-net--c-", | |
| SpeakTest=" "}, | |
| {"typeStep":"browser","arg":"https://ignatandrei.github.io/RSCG_Examples/v2/docs/Bennewitz.Ninja.AutoVersioning#download-example-net--c-", | |
| "SpeakTest": " "}, |
🧰 Tools
🪛 Biome (2.5.3)
[error] 36-36: Property key must be double quoted
(parse)
[error] 36-36: unexpected character =
(parse)
[error] 36-36: expected , but instead found " "
(parse)
[error] 36-36: expected : but instead found }
(parse)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@v2/rscg_examples/Bennewitz.Ninja.AutoVersioning/video.json` around lines 35 -
36, Correct the malformed property definition in the JSON object by using valid
JSON syntax: quote the property name and separate it from its value with a colon
instead of an equals sign. Preserve the existing property value and surrounding
object structure.
Source: Linters/SAST tools
ignatandrei
deleted the
480-httpsgithubcomjanusmaelbennewitzninjaautoversioning
branch
July 16, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation