Repository navigation
feat: add tests for distance tool (geocontext 0.10.x) - #47
Merged
Merged
Conversation
- reference TOOL_DISTANCE in EXPECTED_TOOLS with GEOCONTEXT_DEV=1 - add test_chaining_geocode_distance (Gare de Lyon -> Eiffel Tower on foot) - add test_chaining_distance_piscine_caen (scenario from ignfab/geocontext#207) - document both tests in README Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
(@esgn / @LionelZoubritzky-IGN : I will auto-merge to save time. We will be able to fix / refactor in case of problems) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40
Changes
config/constants.py: addTOOL_DISTANCEtoEXPECTED_TOOLSwhenGEOCONTEXT_DEV=1test_chaining_geocode_distance.py: "Quelle distance à pied entre la gare de Lyon et la tour Eiffel ?" →geocode+distancecalled withprofile=pedestrian, answer in 5-9 kmtest_chaining_distance_piscine_caen.py: scenario ported from Addtimemetric andcarandpedestrianprofiles toDistanceToolgeocontext#207 (New test to port (done with test_chaining_distance_piscine_caen.py but maybe too complex) #38) →geocode,gpf_search_types,gpf_describe_type,gpf_get_features,distance; answer contains "Sivom", "Mondeville" and a walking time in 25-35 minREADME.md: both tests documented in the chaining tests tableBoth tests are skipped without
GEOCONTEXT_DEV=1.Results (local geocontext 0.10.x)
test_tools_discoverytest_chaining_geocode_distancetest_chaining_distance_piscine_caenHaiku fails the Caen scenario: it geocodes the "Lux" tram station and picks the first pool found by
geocode(Campus 1, 52 min) without searching for the nearest one. See the comment in #38 about the relevance of this test.🤖 Generated with Claude Code