Repository navigation
Add GpfIsochroneLayer tool - #211
Open
LionelZoubritzky-IGN wants to merge 1 commit into
Open
LionelZoubritzky-IGN wants to merge 1 commit into
LionelZoubritzky-IGN wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new
gpf_isochrone_layertool that returns the layer for an isochrone query as an opaque proxy url.Related issues (if applicable)
Close #143
Motivation
Test: "Show all places accessible by walking 20 minutes starting from the Orange amphitheater"
Implementation
Rely on existing navigation and itinerary code (based on GPF's isochrone endpoint).
Minor "TRAVEL_TIME" -> "NAVIGATION" refactor.
Add a new "isochrone" token to the proxy.
Testing
New dedicated tests.
npm run build && npm run verify:fast-> 609 tests all greenTODOs
See subsequent PR of the stack: #212 and #214
Checklist