Skip to content

Filter points was outside of the world bounding box - #213

Open
naulan-chrzaszcz wants to merge 1 commit into
mainfrom
naulan/fix-render-points
Open

naulan-chrzaszcz wants to merge 1 commit into
mainfrom
naulan/fix-render-points

Conversation

@naulan-chrzaszcz

Copy link
Copy Markdown
Member

Changes

Filter points was outside of the world bounding box

Feature description

Call filterInside function in RenderPointsTask and RenderPoints2dTask

Reason

Tile 1/1 (x=-250..249, y=-250..249).
Starting task generation:#1
Task generation:#1 finished
Starting task generation:#2
Task generation:#2 finished
Starting task generation:#3
Task generation:#3 finished
Starting task generation:#4
504 status code from Overpass
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
  <meta http-equiv="content-type" content="text/html; charset=utf-8" lang="en"/>
  <title>OSM3S Response</title>
</head>
<body>

<p>The data included in this document is from www.openstreetmap.org. The data is made available under ODbL.</p>
<p><strong style="color:#FF0000">Error</strong>: runtime error: open64: 0 Success /osm3s_osm_base Dispatcher_Client::request_read_and_idx::timeout. The server is probably too busy to handle your request. </p>

</body>
</html>
generation:#4 task failed (try 1 of 11), retrying in 10 seconds.
Task generation:#4 finished
Starting task generation:#5
Task generation:#5 finished
Starting task generation:#6
WorldCoords2d[x=-115, y=-124]
WorldCoords2d[x=-111, y=-179]
WorldCoords2d[x=-96, y=-178]
WorldCoords2d[x=-157, y=-164]
WorldCoords2d[x=-104, y=-161]
WorldCoords2d[x=-185, y=-260]
Error in task generation:#6
Exception in thread "main" com.ignfab.minalac.generator.utils.execution.TaskFailedException: Task failed: generation:#6
        at com.ignfab.minalac.generator.utils.execution.ScheduledTask.lambda$tryExecute$0(ScheduledTask.java:70)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:545)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:328)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1090)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:614)
        at java.base/java.lang.Thread.run(Thread.java:1474)
Caused by: java.lang.IndexOutOfBoundsException: Index out of range at (x=-185, y=-260)
        at com.ignfab.minalac.generator.generation.heightmaps.Heightmap.index(Heightmap.java:54)
        at com.ignfab.minalac.generator.generation.heightmaps.Heightmap.get(Heightmap.java:65)
        at com.ignfab.minalac.generator.generation.heightmaps.ReadableHeightmap.get(ReadableHeightmap.java:31)
        at com.ignfab.minalac.generator.tasks.RenderPoints2dTask.run(RenderPoints2dTask.java:45)
        at com.ignfab.minalac.generator.tasks.RenderPoints2dTask.run(RenderPoints2dTask.java:16)
        at com.ignfab.minalac.generator.tasks.ModelTask.run(ModelTask.java:27)
        at com.ignfab.minalac.generator.tasks.TileTask.run(TileTask.java:13)
        at com.ignfab.minalac.generator.utils.execution.ScheduledTask.lambda$tryExecute$0(ScheduledTask.java:64)
        ... 5 more

Self-checks

  • All examples in examples/ work the same (or have been adapted if subject to changes in this PR)
  • Git history is clean (each commit accomplish a single task and describe it accordingly)

@naulan-chrzaszcz naulan-chrzaszcz self-assigned this Oct 5, 2026
@naulan-chrzaszcz naulan-chrzaszcz added the size: tiny Really small change, can be reviewed very quickly label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

[Maven Build Status]

📑 Commit: 3bc3d5bdaf0da041be52988f2debf5b92cf9012b
⌚️ Date: 2026-10-05T13:57:02 (CEST)
🛠️ Status: ✅ Success

📦 Download artifact: Generator.jar

@pyrollo

pyrollo commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Amusant: 5658f45

@indyteo

indyteo commented Oct 5, 2026

Copy link
Copy Markdown
Member

Je me disais bien que je l'avais déjà vu passer quelque part 😄

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: tiny Really small change, can be reviewed very quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants