Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug描述
当某个直播间设置了「仅通知不录制 = 是」时,主播开播后状态显示「正在直播」,此时手动点击卡片左下角的「开始录制」按钮(播放图标),UI状态会变成录制中,但实际上没有启动FFmpeg录制进程,没有生成视频文件。
复现步骤
预期行为
「仅通知不录制」应该只影响自动录制(开播时不自动录),但手动点击开始录制应该能强制启动录制。
修复方案
在
on_toggle_recording方法中,手动开始录制时临时设置recording.only_notify_no_record = False,调用check_if_live()后再恢复原值。这样check_if_live()会走正常的录制分支,真正启动FFmpeg进程。我已经在自己的Fork里发布了带修复的Release,需要的可以去这里下载:
https://github.com/MAX-2099/StreamCap/releases