Add minimumCost field to illConfig - #781
Merged
Merged
Conversation
jakub-id
approved these changes
Sep 29, 2026
kurtnordstrom
marked this pull request as ready for review
September 29, 2026 19:10
kurtnordstrom
requested review from
JanisSaldabols,
adamdickmeiss and
skomorokh
as code owners
September 29, 2026 19:10
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The field is consistently implemented across the contract, database, API, import workflow, and regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Adds nullable, non-negative minimumCost support across Directory configuration persistence, APIs, and imports.
Changes:
- Adds schema and database support for
minimumCost. - Preserves PATCH semantics and validates negative values.
- Adds API, persistence, and import coverage.
| File | Description |
|---|---|
directory/api.yaml |
Defines minimumCost in API and import schemas. |
directory/api/catalog_config.go |
Maps create and PATCH values to persistence. |
directory/api/entries.go |
Includes the field in entry responses. |
directory/api/loan_config_test.go |
Tests PATCH and null semantics. |
directory/import/model/config.go |
Adds the import model field. |
directory/import/db/entry.go |
Persists imported values. |
directory/import/db/repo_test.go |
Verifies imported database persistence. |
directory/import/service/importer_test.go |
Verifies import decoding. |
directory/query.sql |
Extends the ILL configuration upsert. |
directory/migrations/013_minimum_cost.up.sql |
Adds the constrained database column. |
directory/migrations/013_minimum_cost.down.sql |
Removes the column on rollback. |
directory/test/entries_test.go |
Tests round-trip and partial PATCH behavior. |
directory/test/loan_config_test.go |
Tests validation and persistence through HTTP. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.