Skip to content

Add minimumCost field to illConfig - #781

Merged
kurtnordstrom merged 4 commits into
mainfrom
add_minimum_cost
Sep 29, 2026
Merged

kurtnordstrom merged 4 commits into
mainfrom
add_minimum_cost

Conversation

@kurtnordstrom

Copy link
Copy Markdown
Contributor

No description provided.

@kurtnordstrom
kurtnordstrom marked this pull request as ready for review September 29, 2026 19:10
Copilot AI balanced review requested due to automatic review settings September 29, 2026 19:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The field is consistently implemented across the contract, database, API, import workflow, and regression tests.

Review effort: Balanced
Findings: None

What changed in this PR

Adds nullable, non-negative minimumCost support across Directory configuration persistence, APIs, and imports.

Changes:

  • Adds schema and database support for minimumCost.
  • Preserves PATCH semantics and validates negative values.
  • Adds API, persistence, and import coverage.
File Description
directory/​api.yaml Defines minimumCost in API and import schemas.
directory/​api/​catalog_config.go Maps create and PATCH values to persistence.
directory/​api/​entries.go Includes the field in entry responses.
directory/​api/​loan_config_test.go Tests PATCH and null semantics.
directory/​import/​model/​config.go Adds the import model field.
directory/​import/​db/​entry.go Persists imported values.
directory/​import/​db/​repo_test.go Verifies imported database persistence.
directory/​import/​service/​importer_test.go Verifies import decoding.
directory/​query.sql Extends the ILL configuration upsert.
directory/​migrations/​013_minimum_cost.up.sql Adds the constrained database column.
directory/​migrations/​013_minimum_cost.down.sql Removes the column on rollback.
directory/​test/​entries_test.go Tests round-trip and partial PATCH behavior.
directory/​test/​loan_config_test.go Tests validation and persistence through HTTP.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kurtnordstrom
kurtnordstrom merged commit c1f09a9 into main Sep 29, 2026
10 checks passed
@kurtnordstrom
kurtnordstrom deleted the add_minimum_cost branch September 29, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants