ILLDEV-539 Use NCIP patron info - #785
Merged
Merged
Conversation
jakub-id
requested review from
JanisSaldabols and
adamdickmeiss
as code owners
September 29, 2026 23:05
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
NCIP responses containing patron names and addresses are persisted unsanitized in event logs.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds NCIP patron names and email addresses to borrowing requests while preserving existing patron data.
Changes:
- Extends LMS user lookup options and results.
- Extracts NCIP patron details and enriches ISO 18626 requests.
- Adds adapter and enrichment tests.
Validation: Static review only; tests were not run.
| File | Description |
|---|---|
broker/patron_request/service/action.go |
Enriches patron requests from LMS lookup results. |
broker/patron_request/service/action_test.go |
Tests enrichment behavior and updated mocks. |
broker/lms/lms_adapter.go |
Expands the lookup interface. |
broker/lms/lms_adapter_test.go |
Tests NCIP patron information extraction. |
broker/lms/lms_adapter_ncip.go |
Requests and parses NCIP patron details. |
broker/lms/lms_adapter_manual.go |
Adapts manual lookup to the new interface. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.