Skip to content

Fix oob with inprogress - #54

Merged
adamdickmeiss merged 7 commits into
masterfrom
fix-oob-with-inprogress
Sep 22, 2026
Merged

adamdickmeiss merged 7 commits into
masterfrom
fix-oob-with-inprogress

Conversation

@adamdickmeiss

Copy link
Copy Markdown
Contributor

No description provided.

"*" now correctly uses the trailing-wildcard branch,
empty patterns are safe, and "*/" retains precedence.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Handle EAGAIN/EWOULDBLOCK correctly before closing healthy proxy connections.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Fixes proxy receive handling to prevent out-of-bounds access and improves URL wildcard matching.

Changes:

  • Safely handles non-positive proxy reads.
  • Corrects ZURL wildcard matching and empty-pattern handling.
  • Receive-side would-block errors still need separate handling from EINPROGRESS.
File Summary
src/​http.c Prevents indexing the buffer with a negative receive result.
src/​database.c Corrects URL wildcard matching logic.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/http.c Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The nonblocking retry check must be made platform-aware before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)

Comment thread src/http.c Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

src/http.c should handle EWOULDBLOCK as an in-progress read condition.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)

Comment thread src/http.c Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Preserve diagnostic warnings for negative recv() errors before approval.

Review effort: Lite
Findings: None

Resolved since last review (1)

@adamdickmeiss
adamdickmeiss merged commit 4441417 into master Sep 22, 2026
3 checks passed
@adamdickmeiss
adamdickmeiss deleted the fix-oob-with-inprogress branch September 25, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants