composer, cleanup - #31
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are straightforward metadata/packaging cleanup and align with the current build configuration (notably config.m4 not supporting a --with-yaz=PATH argument).
Pull request overview
This PR modernizes project metadata by adding Composer package information and removing legacy Windows Visual Studio 6 project packaging artifacts, keeping the PECL package manifest aligned with the actual build configuration.
Changes:
- Removed the legacy
yaz.dspVisual Studio project file. - Added a
composer.jsonmanifest and included it inpackage.xml. - Simplified
package.xml’s<extsrcrelease>metadata by removing the outdatedwith-yazpath configure option.
File summaries
| File | Description |
|---|---|
yaz.dsp |
Removes obsolete Visual Studio 6 project file from the repo/package surface. |
package.xml |
Updates PECL package contents to include composer.json, drops yaz.dsp, and removes outdated configure metadata. |
composer.json |
Introduces Composer metadata for the extension/package. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.