Rerequest ILLDEV-530 - #60
Merged
Merged
Conversation
skomorokh
requested review from
adamdickmeiss,
ihardy,
jakub-id and
kurtnordstrom
as code owners
September 28, 2026 23:23
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The workflow does not consistently gate on noop support and can leave request-event caches stale after failures.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds an editable rerequest workflow for creating revised, linked patron requests.
Changes:
- Adds rerequest routing, action UI, validation, and error handling.
- Adds revision payload mapping and shared form infrastructure.
- Adds comprehensive rerequest and flow tests plus translations.
| File | Description |
|---|---|
ui-rs/translations/ui-rs/en.json |
Adds rerequest messages. |
ui-rs/src/routes/RerequestRoute.test.js |
Tests rerequest workflows and failures. |
ui-rs/src/routes/RerequestRoute.js |
Implements the revision route. |
ui-rs/src/routes/FlowRoute.test.js |
Tests rerequest action navigation. |
ui-rs/src/routes/EditRoute.js |
Adopts shared form handling. |
ui-rs/src/routes/CreateRoute.js |
Adopts shared form handling. |
ui-rs/src/index.js |
Registers the rerequest route. |
ui-rs/src/components/PatronRequestForm/submissionError.js |
Centralizes submission errors. |
ui-rs/src/components/PatronRequestForm/PatronRequestFormPane.js |
Adds reusable form layout. |
ui-rs/src/components/PatronRequestForm/formMapping.js |
Builds revision payloads. |
ui-rs/src/components/Flow/moreActions/Rerequest.js |
Adds the rerequest action button. |
ui-rs/src/components/Flow/moreActions/index.js |
Exports the new action. |
ui-rs/src/components/Flow/actionMeta.js |
Adds rerequest metadata. |
stripes-reshare/translations/stripes-reshare/en.json |
Adds the action label. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.