Don't require pickup location when none can be selected - #61
Merged
Merged
Conversation
jakub-id
requested review from
adamdickmeiss,
ihardy,
kurtnordstrom and
skomorokh
as code owners
September 29, 2026 10:33
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The validation change is focused and adequately covered by route-level tests.
Review effort: Balanced
Findings: None
What changed in this PR
Allows loan requests to proceed when no pickup locations are available.
Changes:
- Requires pickup location only when selectable locations exist.
- Adds coverage for failed, empty, and institution-only lookups.
| File | Description |
|---|---|
PatronRequestForm.js |
Makes pickup-location validation conditional on available options. |
CreateRoute.test.js |
Verifies submission without available pickup locations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.