ILLDEV-537 Use illConfig.isPickupLocation to mark pickup locations - #63
Merged
Merged
Conversation
jakub-id
requested review from
adamdickmeiss,
ihardy,
kurtnordstrom and
skomorokh
as code owners
September 29, 2026 13:24
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Saving the flag leaves the cached owned-entry pickup options stale for up to five minutes.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Uses illConfig.isPickupLocation to control which owned directory entries are offered as requester pickup locations.
Changes:
- Adds an editable pickup-location flag and label.
- Filters pickup options by the new flag.
- Updates create/edit route fixtures and coverage.
| File | Description |
|---|---|
ui-rsdir/translations/ui-rsdir/en.json |
Adds the flag label. |
ui-rsdir/src/routes/ILLConfigRoute.js |
Exposes the boolean setting. |
ui-rs/src/util/useOwnedEntries.js |
Filters pickup locations by the flag. |
ui-rs/src/routes/EditRoute.test.js |
Updates flagged-entry fixtures. |
ui-rs/src/routes/CreateRoute.test.js |
Tests inclusion and exclusion behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jakub-id
changed the title
skomorokh
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't rely on
lmsConfig.requesterPickupLocationto mark a pickup location since we need them supported also when NCIP is disabled.