Align Z39.50 definitions and documentation with the 2003 standard - #210
Merged
Merged
Conversation
adamdickmeiss
commented
Sep 21, 2026
adamdickmeiss
commented
Contributor
- Rename the ASN.1 module and imports to Z39-50-APDU-2001, preserving the OID and generated C API/ABI.
- Document YAZ compatibility extensions and defer PeriodicQuerySchedule corrections to YAZ 6.
- Update standards documentation and clarify Bib-1 diagnostic compatibility; restore the complete diagnostic 1064 message without changing its macro.
- Remove the unused attribute CSV and expand the bib1-attr.7 source with registered Use and Relation attributes.
- Rename the ASN.1 module and imports to Z39-50-APDU-2001, preserving the OID and generated C API/ABI. - Document YAZ compatibility extensions and defer PeriodicQuerySchedule corrections to YAZ 6. - Update standards documentation and clarify Bib-1 diagnostic compatibility; restore the complete diagnostic 1064 message without changing its macro. - Remove the unused attribute CSV and expand the bib1-attr.7 source with registered Use and Relation attributes.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Preserve the existing public diagnostic 1064 macro name while retaining the complete lookup message.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates YAZ’s Z39.50 ASN.1 definitions and documentation toward the 2003 standard while preserving compatibility.
Changes:
- Renames ASN.1 modules and imports while retaining generated API/ABI mappings.
- Documents compatibility exceptions and diagnostic behavior.
- Expands Bib-1 attribute documentation and removes unused data.
| File | Summary |
|---|---|
src/z3950v3.asn |
Updates module naming and compatibility documentation. |
src/z.tcl |
Preserves generated filenames and prefixes for the renamed module. |
src/univres.asn |
Updates the core module import. |
src/oid.csv |
Removes trailing whitespace. |
src/mterm2.asn |
Updates the core module import. |
src/facet.asn |
Updates the core module import. |
src/esupdate.asn |
Updates the core module import. |
src/esadmin.asn |
Updates the core module import. |
src/datetime.asn |
Updates the core module import. |
src/bib1.csv |
Restores diagnostic 1064 text and updates metadata. |
src/attset_bib1.csv |
Removes unused attribute data. |
doc/book.xml |
Documents standards alignment and compatibility exceptions. |
doc/bib1-attr-man.xml |
Expands registered Bib-1 attribute documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.