Refresh tool window theme when the IDE theme changes - #114
Open
Bazooper-blip wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4.
DelphiLint applied the IDE theme to its windows only when they were created, and nothing listened for theme changes — so after switching the IDE theme, the DelphiLint tool window kept the old theme.
Changes, following the existing editor-notifier pattern:
DelphiLint.Context.pas: newIIDEThemeChangeHandlerinterface, plusAddThemeChangeNotifier/RemoveThemeChangeNotifieronIIDEServicesunder the theming services section.DelphiLint.Handlers.pas:TThemeChangeHandler, aTHandlerthat invokes a callback on theme change.DelphiLint.IDEContext.pas:TToolsApiThemeNotifierbridgesINTAIDEThemingServicesNotifier.ChangedThemeto the handler, registered viaIOTAIDEThemingServices.AddNotifier.DelphiLint.Plugin.pas: registers the notifier on plugin registration, removes it on deregistration, and re-applies the theme to the tool window when the theme changes.DelphiLintTest.MockContext.pas: mock support for the newIIDEServicesmethods.Testing: compiles on Delphi 13 and the DUnitX suite passes at the same rate as master. I'd appreciate a manual double-check of theme switching with the DelphiLint window open (docked and floating).